Add messageFallback property #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any change to get this merged soon? |
|
Hey @spyric! I'm checking your proposal, is that a feature defined on Laravel's translator API ? The aim of this library is to provides API-compatible to laravel localization helper. :) |
|
Hello @rmariuzzo . In fact it's not. But Laravel gives ability to register custom translator and handle missed translations. Currently there is no way to handle missed translations that occured in JS files, so I offered optional thing that will give ability to track it. |
|
Great! Let me think a little about it and comes to a conclusion. Thank you
for replying.
…On Jul 24, 2017 14:35, "Egor Talantsev" ***@***.***> wrote:
Hello @rmariuzzo <https://github.com/rmariuzzo> . In fact it's not.
But Laravel gives ability to register custom translator and handle missed
translations. Currently there is no way to handle missed translations that
occured in JS files, so I offered optional thing that will give ability to
track it.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#44 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAa2HydO7ru7SfKtsaZM7ymj5S7EdaiJks5sROP9gaJpZM4NUWmx>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives ability to notify application's owner about translation that is not exists in translation file.